Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LoadPodFromFile to volume utils #47514

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Move LoadPodFromFile to volume utils #47514

merged 2 commits into from
Jun 26, 2017

Conversation

jsafrane
Copy link
Member

SavePodToFile is not used anywhere and LoadPodFromFile is used only by PV
recycler.

Fix #16970

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 14, 2017
@jsafrane
Copy link
Member Author

@smarterclayton, you're author of the original issue, PTAL (and approve)

@jsafrane
Copy link
Member Author 

W0614 05:50:30.025] Errors from golint:
W0614 05:50:30.025] pkg/util/io/writer.go:39:1: exported method StdWriter.WriteFile should have comment or be unexported
W0614 05:50:30.025] pkg/util/io/writer.go:43:1: comment on exported type NsenterWriter should be of the form "NsenterWriter ..." (with optional leading article)
W0614 05:50:30.025] pkg/util/io/writer.go:53:1: comment on exported method NsenterWriter.WriteFile should be of the form "WriteFile ..."
W0614 05:50:30.026] pkg/util/io/writer.go:56:2: don't use underscores in Go names; var base_args should be baseArgs
W0614 05:50:30.026] pkg/util/io/writer.go:61:2: don't use underscores in Go names; var echo_args should be echoArgs
W0614 05:50:30.026] pkg/util/io/writer.go:71:2: don't use underscores in Go names; var chmod_args should be chmodArgs

I wonder how removal of pkg/util/io/io.go caused these golint errors to appear. Fixed in the second patch.

@sjenning
Copy link
Contributor

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, smarterclayton

Associated issue: 16970

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@jsafrane
Copy link
Member Author

rebased

@jsafrane jsafrane added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2017
@jsafrane
Move LoadPodFromFile to volume utils
c2dc5b5 
SavePodToFile is not used anywhere and LoadPodFromFile is used only by PV
recycler.
@jsafrane
Copy link
Member Author

rebased (restoring lgtm...)

@jsafrane
Fix lint errors
b73517d 
Removal of io.go revealed new lint errors in pkg/util/io
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2017
@jsafrane jsafrane added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48074, 47971, 48044, 47514, 47647)

@k8s-github-robot k8s-github-robot merged commit eaa6571 into kubernetes:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjenning sjenning

@smarterclayton smarterclayton

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @sjenning @smarterclayton @k8s-github-robot @luxas @k8s-ci-robot